Fix warning in getTraceAsString #6768
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
approved these changes
Mar 13, 2021
morrisonlevi
force-pushed
the
trace/unknown-file
branch
from
4cd6866 to
340ae97
Compare
|
@derickr, @sgolemon, @petk , or @carusogabriel: any thoughts on merging this into 7.4 and/or 8.0? |
morrisonlevi
force-pushed
the
trace/unknown-file
branch
from
340ae97 to
09af94a
Compare
The error says "Function name" is not a string, but it's actually investigating the "file" field, not "function".
morrisonlevi
force-pushed
the
trace/unknown-file
branch
from
09af94a to
2ae3fa0
Compare
|
On 17 March 2021 03:34:18 GMT, Levi Morrison ***@***.***> wrote:
***@***.***, @sgolemon, @petk , or @carusogabriel: any thoughts on merging
this into 7.4 and/or 7.0?
I've problems with merging it into 7.0 (I hope you meant 8.0?), but feel free to merge this into 7.4; it's clearly just a bug fix.
cheers,
Derick
|
carusogabriel
approved these changes
Mar 17, 2021
|
No rush, I'll merge it in and it'll go out when it goes out. It's harmless, so no rush, |
|
I'm now waiting on the updated merge workflow after the move to github. |
|
The workflow doesn't change; you only have to change your remote to point to Github instead of git.php.net. |
|
Merged into 8.0, as it didn't apply cleanly to 7.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a long-standing and harmless bug.
The error says "Function name" is not a string, but it's actually
investigating the "file" field, not "function".
Simplify line number branches as well.